Add support for Rgbic Neon Rope Light#452
Open
XiaoLing-git wants to merge 10 commits intosblibs:masterfrom
Open
Add support for Rgbic Neon Rope Light#452XiaoLing-git wants to merge 10 commits intosblibs:masterfrom
XiaoLing-git wants to merge 10 commits intosblibs:masterfrom
Conversation
XiaoLing-git
commented
Feb 28, 2026
XiaoLing-git
commented
- Rgbic Neon Rope Light
- Rgbic Neon Wire Rope Light
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds initial support for SwitchBot RGBIC Neon Rope Light / Neon Wire Rope Light by extending model constants, advertisement parsing, and introducing a dedicated neon light-strip device class, with accompanying test updates.
Changes:
- Add new
SwitchbotModelentries for RGBIC Neon Rope Light and RGBIC Neon Wire Rope Light. - Extend
adv_parser.SUPPORTED_TYPESto recognize the new model identifiers. - Add
SwitchbotRgbicNeonLightdevice class and update tests to include the new model.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
switchbot/const/__init__.py |
Adds enum constants for the two new neon models. |
switchbot/adv_parser.py |
Adds SUPPORTED_TYPES entries for new neon rope/wire model IDs. |
switchbot/devices/light_strip.py |
Introduces SwitchbotRgbicNeonLight (RGB-only) device class. |
switchbot/__init__.py |
Exports SwitchbotRgbicNeonLight from the package. |
tests/test_adv_parser.py |
Adds advertisement parsing test vectors for RGBIC Neon Rope Light. |
tests/__init__.py |
Adds RGBIC_NEON_LIGHT_INFO test fixture data. |
tests/test_strip_light.py |
Adds neon device to parametrized strip-light tests and adjusts assertions. |
.idea/workspace.xml |
Adds IDE workspace file (should not be committed). |
Files not reviewed (1)
- .idea/workspace.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bdraco
requested changes
Mar 13, 2026
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
There are unrelated changes in this PR
zerzhang
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.